Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalculateGenotypePosteriors allows input VCFs from different references #4383

Open
ldgauthier opened this issue Feb 9, 2018 · 2 comments
Open

Comments

@ldgauthier
Copy link
Contributor

#2410 added the --sequenceDictionary argument, but how do we make this argument required for certain tools? The GTEx project uses CalculateGenotypePosteriors (yay!) and accidentally mixed and matched some VCFs with understandably unexpected results.

@droazen
Copy link
Contributor

droazen commented Feb 9, 2018

@ldgauthier The easiest way to do this right now is to call getMasterSequenceDictionary() from the tool's onTraversalStart() method, and throw if it returns null.

@droazen
Copy link
Contributor

droazen commented Feb 9, 2018

I'll also mention that as part of #4341 we plan to give tools more control over the arguments inherited from GATKTool, including selectively disabling and redefining engine arguments, so once a mechanism is in place for that CalculateGenotypePosteriors could make --sequence-dictionary required. Currently this ability only exists for a few GATKTool arguments, and the tool has to override methods like requiresReads() to make use of it. Until the ability to do this is generalized, recommend the stopgap solution with the check in onTraversalStart() + a note in the tool's docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants