Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in --tmp-dir argument in GenomicsDB docs #6785

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

gbrandt6
Copy link
Contributor

@gbrandt6 gbrandt6 commented Sep 1, 2020

Documentation change for tmp dir in example command - GenomicsDB tool docs

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you. Looks good to me.

@lbergelson
Copy link
Member

@gbrandt6 So now the protocol is that you wait for tests to pass (although it's unlikely this could break them...) and then you can merge with "squash and merge". You can edit the commit message in the browser to make sure it is clear. Fix typo in --tmp-dir argument in GenomicsDB docs is a pretty good description for this one though :)

@lbergelson
Copy link
Member

Sorry if you know that already. I wasn't sure if you've merge PR's before.

@droazen droazen merged commit 56a6bcf into master Sep 1, 2020
@droazen droazen deleted the GB_tmp_dir_documentation-2 branch September 1, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants