Adding mode and 95th percentile to InsertSizeMetrics. #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yfarjoun or @lbergelson bump? |
ktibbett
reviewed
Dec 15, 2017
| @@ -168,6 +169,7 @@ public void addMetricsToFile(final MetricsFile<InsertSizeMetrics,Integer> file) | |||
| if (percentCovered >= 0.7 && metrics.WIDTH_OF_70_PERCENT == 0) metrics.WIDTH_OF_70_PERCENT = distance; | |||
| if (percentCovered >= 0.8 && metrics.WIDTH_OF_80_PERCENT == 0) metrics.WIDTH_OF_80_PERCENT = distance; | |||
| if (percentCovered >= 0.9 && metrics.WIDTH_OF_90_PERCENT == 0) metrics.WIDTH_OF_90_PERCENT = distance; | |||
| if (percentCovered >= 0.9 && metrics.WIDTH_OF_95_PERCENT == 0) metrics.WIDTH_OF_95_PERCENT = distance; | |||
There was a problem hiding this comment.
@nh13 shouldn't this be percentCovered >= 0.95 ?
There was a problem hiding this comment.
No description provided.
|
@ktibbett one more time, omg that mistake. |
|
I'm concerned that the tests passed with that error....could we have tests that would fail on that error? |
nh13
force-pushed
the
nh_insert_size_mode_and_95_percentile
branch
from
acf57a1
to
cf190f5
Compare
|
@yfarjoun of course, done. |
nh13
commented
Dec 15, 2017
| Assert.assertEquals(metric.WIDTH_OF_80_PERCENT, 1 + insertBy*14); | ||
| Assert.assertEquals(metric.WIDTH_OF_90_PERCENT, 1 + insertBy*16); | ||
| Assert.assertEquals(metric.WIDTH_OF_95_PERCENT, 1 + insertBy*18); | ||
| Assert.assertEquals(metric.WIDTH_OF_99_PERCENT, 1 + insertBy*20); |
There was a problem hiding this comment.
Look Ma, different values for each!
|
Thanks @nh13 : 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find that I parse the histogram often for these metrics, and so I figured I should just go ahead and add them officially.