Bug fix: CollectWgsMetricsWithNonZeroCoverage fails to produce a plot #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yfarjoun or @lbergelson, care to take a look? This happens when we have zero coverage data (yikes!). |
yfarjoun
reviewed
Dec 15, 2017
when there is zero coverage. Also fixed up a few warnings.
nh13
force-pushed
the
nh_wgs_nonzero_plot_fixup
branch
from
e2f1618
to
069f54b
Compare
|
@yfarjoun good idea, I added in a test to make sure the pdf is created. I squashed the commits to be ready for the merge. |
|
Thanks. in the future, please refrain from squashing. We can easily squash in github and it only makes reviewing more difficult. (in this case, it's really not a problem since the changes are so minimal...) |
|
Looks great! thanks for the fix and test! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when there is zero coverage.
Also fixed up a few warnings.