Adding more features support in SSL certificates #15
Conversation
trolldbois
commented
Apr 10, 2020
trolldbois
commented
- Support parameters in "Listing SSL Certificates" to allow searching for specific certificates
- Add support for "Get SSL Certificate" by cert sslId
|
@trolldbois sorry it took a while to circle back to this. Can you rebase on current master as there are conflicts here now. We are also dropping Python 2.7 support, so that should clear up some of the tests after the rebase as well. |
|
Any update on this? Anything I can help with? This functionality would be useful for me. |
|
This functionality would be useful for me as well. Would also like to know if there are any updates. |
|
There were a couple comments here that didn't seem to get addressed. Additionally, we have also transitioned to the |
|
@trolldbois I updated the base branch to |
|
@trolldbois I will approve/merge these changes if you can rebase to resolve the conflict and the remaining comments |
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 95.38% 92.64% -2.75%
==========================================
Files 11 11
Lines 412 435 +23
==========================================
+ Hits 393 403 +10
- Misses 19 32 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
|
||
| @paginate | ||
| def list(self, **kwargs): | ||
| # size, position, commonName, subjectAlternativeName, status , sslTypeId |
There was a problem hiding this comment.
Probably replace all these comments with a link to the doc:
https://sectigo.com/uploads/audio/Certificate-Manager-20.1-Rest-API.html#resource-SSL-list
| from requests.exceptions import HTTPError | ||
|
|
||
| from ._helpers import Pending | ||
| from ._endpoint import Endpoint |
There was a problem hiding this comment.
Only the from ._helpers import paginate import is needed here, right?
