Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom exception #7

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Replace custom exception #7

merged 1 commit into from
Apr 4, 2019

Conversation

coreone
Copy link
Member

@coreone coreone commented Mar 28, 2019

  • Replace old custom exception HttpError with the default HTTPError exception that comes with the requests library
  • Fix all unit tests for all changes
  • Fix some bad hard-coding in tests/test_traffic_log.py
  • Use json.dumps in tests/test_traffic_log.py to get more consistent results
  • Fix tag in dev.sh
  • Add coding pragma to the top of all python files
  • Add a pre-commit check to make sure coding pragma is always present
  • Add tag verification to setup.py
  • README update for release info
  • CircleCI changes for environment variables
  • Ignore .bumpversion.cfg in pre-commit due to the way it rewrites the file (extra newline)
  • Bump version: 0.1.0 → 1.0.0

@coreone coreone requested a review from a team as a code owner March 28, 2019 21:19
@coreone coreone force-pushed the exceptions branch 2 times, most recently from 7dc5c95 to 27ddf22 Compare April 2, 2019 20:25
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #7 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   94.54%   94.42%   -0.12%     
==========================================
  Files          10       10              
  Lines         330      323       -7     
==========================================
- Hits          312      305       -7     
  Misses         18       18
Flag Coverage Δ
#unittests 94.42% <100%> (-0.12%) ⬇️
Impacted Files Coverage Δ
cert_manager/smime.py 100% <ø> (ø) ⬆️
cert_manager/_endpoint.py 100% <ø> (ø) ⬆️
cert_manager/person.py 100% <ø> (ø) ⬆️
cert_manager/ssl.py 100% <ø> (ø) ⬆️
cert_manager/organization.py 100% <ø> (ø) ⬆️
cert_manager/_helpers.py 75% <100%> (-3.83%) ⬇️
cert_manager/_certificates.py 100% <100%> (ø) ⬆️
cert_manager/client.py 100% <100%> (ø) ⬆️
cert_manager/__version__.py 100% <100%> (ø) ⬆️
cert_manager/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca77a2c...b8f622d. Read the comment docs.

@coreone coreone force-pushed the exceptions branch 6 times, most recently from 7902720 to a98d480 Compare April 4, 2019 12:07
…r` exception that comes with the *requests* library

* Fix all unit tests for all changes
* Fix some bad hard-coding in `tests/test_traffic_log.py`
* Use `json.dumps` in `tests/test_traffic_log.py` to get more consistent results
* Fix tag in dev.sh
* Add coding pragma to the top of all python files
* Add a pre-commit check to make sure coding pragma is always present
* Add tag verification to `setup.py`
* README update for release info
* CircleCI changes for environment variables
* Ignore .bumpversion.cfg in pre-commit due to the way it rewrites the file (extra newline)
* Bump version: 0.1.0 → 1.0.0
@coreone coreone merged commit c29b52e into master Apr 4, 2019
@coreone coreone deleted the exceptions branch April 4, 2019 16:16
@coreone coreone added bug Something isn't working enhancement New feature or request labels Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants