Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ported code from cromwell #351

Merged
merged 1 commit into from
Mar 23, 2016
Merged

ported code from cromwell #351

merged 1 commit into from
Mar 23, 2016

Conversation

dvoet
Copy link
Contributor

@dvoet dvoet commented Mar 22, 2016

work around for slick deadlock slick/slick#1274

  • Submitter: Rebase to develop. DO NOT SQUASH
  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: Make sure documentation for code is complete
  • Submitter: Make sure liquibase is updated if appropriate
  • Submitter: Review code comments; remove done TODOs, create stories for remaining TODOs
  • Submitter: Include the JIRA issue number in the PR description
  • Submitter: Add description or comments on the PR explaining the hows/whys (if not obvious)
  • Tell that the PR exists if he wants to look at it
  • Anoint a lead reviewer (LR). Assign PR to LR
  • LR: Initial review by LR and others.
  • Comment / review / update cycle:
    • Rest of team may comments on PR at will
    • LR assigns to submitter for feedback fixes
    • Submitter updates documentation as needed
    • Submitter rebases to develop again if necessary
    • Submitter makes further commits. DO NOT SQUASH. Reassign to LR for further feedback
  • sign off
  • LR sign off
  • Assign to submitter to finalize
  • Submitter: Squash commits, rebase if necessary
  • Submitter: Verify all tests go green, including CI tests
  • Submitter: Merge to develop
  • Submitter: Delete branch after merge
  • Submitter: Check configuration files in Jenkins in case they need changes
  • Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
  • Submitter: Verify swagger UI on dev environment still works after deployment
  • Submitter: Inform other teams of any API changes via hipchat and/or email
  • Submitter: Mark JIRA issue as resolved once this checklist is completed

@MatthewBemis
Copy link
Member

:shipit:

@MatthewBemis MatthewBemis assigned dvoet and unassigned MatthewBemis Mar 22, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 77.99% when pulling 159be69de449818570109ab6580874ff966548da on slick_deadlock into 8c7fd44 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 77.99% when pulling c6dde10 on slick_deadlock into 3490589 on develop.

@dvoet dvoet merged commit 30bd352 into develop Mar 23, 2016
@dvoet dvoet deleted the slick_deadlock branch March 23, 2016 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants