add list actions api #284
Merged
add list actions api #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2919
💛 - Coveralls |
Qi77Qi
reviewed
Mar 14, 2019
|
|
||
| Get(s"/api/resources/v1/${resourceType.name}/foo/actions") ~> samRoutes.route ~> check { | ||
| status shouldEqual StatusCodes.OK | ||
| responseAs[Set[String]] |
There was a problem hiding this comment.
do you mean to do some assert on the response?
There was a problem hiding this comment.
no, this only checks that it can be parsed
There was a problem hiding this comment.
Shall we check the actions with expected ones? or is it not feasible to do that?
There was a problem hiding this comment.
the purpose of the test is to check that the route exists, returns the right status code and the right format of data. Correctness of that data is tested by a service level test.
Qi77Qi
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
adding an api to list the user's actions on a resource to help with performance on the rawls get workspace call (which currently makes 5 api calls to sam)
PR checklist