-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add list actions api #284
add list actions api #284
Conversation
Pull Request Test Coverage Report for Build 2919
💛 - Coveralls |
|
||
Get(s"/api/resources/v1/${resourceType.name}/foo/actions") ~> samRoutes.route ~> check { | ||
status shouldEqual StatusCodes.OK | ||
responseAs[Set[String]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean to do some assert on the response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this only checks that it can be parsed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we check the actions with expected ones? or is it not feasible to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the purpose of the test is to check that the route exists, returns the right status code and the right format of data. Correctness of that data is tested by a service level test.
Ticket:
adding an api to list the user's actions on a resource to help with performance on the rawls get workspace call (which currently makes 5 api calls to sam)
PR checklist