Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moving scientific ownership to sam lee instead of laura #790

Merged
merged 3 commits into from
Aug 18, 2022
Merged

moving scientific ownership to sam lee instead of laura #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e36f818
moving scientific ownership to sam lee instead of laura
nikellepetrillo Aug 9, 2022
ff7a612
Merge branch 'develop' into np_update_pullapprove
nikellepetrillo Aug 17, 2022
4a01e8b
Merge branch 'develop' into np_update_pullapprove
nikellepetrillo Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .pullapprove.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ groups:
'tasks/broad/IlluminaGenotypingArrayTasks.wdl' in files or
'tasks/broad/InternalArraysTasks.wdl' in files or
'tasks/broad/InternalTasks.wdl' in files or
'tasks/broad/Qc.wdl' in files or
'tasks/broad/Utilities.wdl' in files or
'verification/VerifyArrays.wdl' in files or
'verification/VerifyIlluminaGenotypingArray.wdl' in files or
Expand Down Expand Up @@ -138,6 +139,8 @@ groups:
'tasks/broad/BamProcessing.wdl' in files or
'tasks/broad/BamToCram.wdl' in files or
'tasks/broad/CopyFilesFromCloudToCloud.wdl' in files or
'tasks/broad/DragenTasks.wdl' in files or
'tasks/broad/DragmapAlignment.wdl' in files or
'tasks/broad/GermlineVariantDiscovery.wdl' in files or
'tasks/broad/Qc.wdl' in files or
'tasks/broad/SplitLargeReadGroup.wdl' in files or
Expand All @@ -148,6 +151,7 @@ groups:
'verification/VerifyReprocessing.wdl' in files or
'verification/VerifyTasks.wdl' in files or
'pipelines/broad/dna_seq/germline/single_sample/exome' in files or
'pipelines/broad/dna_seq/germline/single_sample/ugwgs' in files or
'pipelines/broad/dna_seq/germline/single_sample/wgs' in files or
'pipelines/broad/reprocessing/cram_to_unmapped_bams' in files or
'pipelines/broad/reprocessing/exome' in files or
Expand All @@ -160,7 +164,7 @@ groups:
request: 2
reviewers:
users:
- ldgauthier # Laura Gauthier
- samuelklee # Samuel Lee
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to help review any changes to these pipelines, but strictly speaking, I think Laura only handed off responsibilities for the joint-genotyping pipelines to me. Perhaps @kachulis can clarify who the primary owner for the single-sample pipelines will be going forward?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Or if it turns out that I do own these now, it would be good to sort that out!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK---chatted with Chris and I understand the intended split now. He'll own everything up through alignment/duplicate marking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks sam! that sounds good 👍

- kachulis # Chris Kachulis

scientific_owners_joint_genotyping:
Expand All @@ -173,13 +177,19 @@ groups:
'pipelines/broad/dna_seq/germline/joint_genotyping/by_chromosome/JointGenotypingByChromosomePartOne.wdl' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/by_chromosome/JointGenotypingByChromosomePartTwo.wdl' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/reblocking/ReblockGVCF.wdl' in files or
'tasks/broad/GermlineVariantDiscovery.wdl' in files or
'tasks/broad/JointGenotypingTasks.wdl' in files or
'tasks/broad/Qc.wdl' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/JointGenotyping.changelog.md' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/JointGenotyping.options.json' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/JointGenotyping.wdl' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/JointGenotypingOnReblockedValidate.md' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/UltimaGenomics' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/by_chromosome' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/exome' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/reblocking' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/test_data_overview.md' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/test_inputs' in files or
'pipelines/broad/dna_seq/germline/joint_genotyping/wgs' in files

reviews:
Expand All @@ -189,7 +199,7 @@ groups:
request_order: given
reviewers:
users:
- ldgauthier # Laura Gauthier
- samuelklee # Samuel Lee

scientific_owners_somatic_single_sample:
conditions:
Expand All @@ -203,6 +213,7 @@ groups:
'tasks/broad/Alignment.wdl' in files or
'tasks/broad/BamProcessing.wdl' in files or
'tasks/broad/BamToCram.wdl' in files or
'tasks/broad/DragmapAlignment.wdl' in files or
'tasks/broad/Qc.wdl' in files or
'tasks/broad/SplitLargeReadGroup.wdl' in files or
'tasks/broad/UnmappedBamToAlignedBam.wdl' in files or
Expand Down Expand Up @@ -235,7 +246,8 @@ groups:
'pipelines/broad/arrays/imputation/Imputation.changelog.md' in files or
'pipelines/broad/arrays/imputation/Imputation.options.json' in files or
'pipelines/broad/arrays/imputation/Imputation.wdl' in files or
'pipelines/broad/arrays/imputation/example_inputs.json' in files
'pipelines/broad/arrays/imputation/example_inputs.json' in files or
'pipelines/broad/arrays/imputation/test_inputs' in files

reviews:
required: 1
Expand All @@ -262,6 +274,8 @@ groups:
'tasks/broad/Alignment.wdl' in files or
'tasks/broad/BamProcessing.wdl' in files or
'tasks/broad/BamToCram.wdl' in files or
'tasks/broad/DragenTasks.wdl' in files or
'tasks/broad/DragmapAlignment.wdl' in files or
'tasks/broad/GermlineVariantDiscovery.wdl' in files or
'tasks/broad/Qc.wdl' in files or
'tasks/broad/SplitLargeReadGroup.wdl' in files or
Expand Down
4 changes: 2 additions & 2 deletions pullapprove_template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ groups:
request: 2
reviewers:
users:
- ldgauthier # Laura Gauthier
- samuelklee # Samuel Lee
- kachulis # Chris Kachulis

scientific_owners_joint_genotyping:
Expand All @@ -108,7 +108,7 @@ groups:
request_order: given
reviewers:
users:
- ldgauthier # Laura Gauthier
- samuelklee # Samuel Lee

scientific_owners_somatic_single_sample:
conditions:
Expand Down