-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GL-2055: Updated Build_indices container and Fixes on corresponding WDL #830
Conversation
…mendations in Warp's docker style guide. Local build currently fails even without modifications, currently investigating why.
…o a more recent Debian version (Bullseye) so tini is part of apt. An upgrade of python was attempted too but pip failed as it can't find old versions of libraries listed in requirements.txt.
… exist. This fixes that error.
Remember to squash merge! |
It looks like the Pipeline changelog validation and Pipeline release validation checks are failing. If you click into the Details, on the changelog validation test and then click console output, you will see in the log "BuildIndices.changelog.md has not been changed and needs to be updated" We have changelogs that sit next to each pipeline. Every time we update a pipeline or a task the pipeline uses, we need to:
|
Remember to squash merge! |
Remember to squash merge! |
@@ -0,0 +1,2 @@ | |||
us.gcr.io/broad-gotc-prod/build-indices:1.0.0-2.7.10a-1663343355 | |||
us.gcr.io/broad-gotc-prod/build-indices:1.0.0-2.7.10a-1663605340 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For uniformity with the other images add DOCKER_VERSION
to the topmost line and remove older versions not in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Remember to squash merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Remember to squash merge! |
@nikellepetrillo - Looks like I need another reviewer before I can merge. Can you take a look? Thank you! |
WDL fixes:
Tested on Cromwell server https://cromwell.gotc-dev.broadinstitute.org
Succeeding run under the workflow ID: 41fa197d-1b47-4647-9d4f-6504b801c8f2