repeated 'pager' entry in prototype for pager class

[BillDunlap]

In CRAN's diffobj-0.2.2 R/pager.R provides two 'pager' entries in the prototype for class 'Pager'. That seems wrong and one of them should be omitted. Currently the second, which calls stop(), is the one used, but it seems like the first would be a better default value.

setClass(
  "Pager",
  slots=c(
    pager="function", file.ext="character", threshold="numeric",
    ansi="logical", file.path="character", make.blocking="logical"
  ),
  prototype=list(
    pager=function(x) writeLines(readLines(x)), file.ext="", threshold=0L,
    pager=function(x) stop("Pager object does not specify a paging function."),
    ansi=FALSE, file.path=NA_character_, make.blocking=FALSE
  )

[brodieG]

Obviously this is an oversight. Thanks for reporting. Looking at the blame it appears that I intended the first one to be the new setting, and clearly failed to test for that properly:

01648246 (brodieG 2016-04-30 21:54:15 -0400 231) setClass(
9b4e424c (brodieG 2016-05-07 20:45:37 -0400 232)   "Pager",
a73cad91 (brodieG 2016-11-05 21:17:15 -0400 233)   slots=c(
269bf03d (brodieG 2016-11-06 10:46:50 -0500 234)     pager="function", file.ext="character", threshold="numeric",
98148365 (brodieG 2019-01-01 20:39:54 -0500 235)     ansi="logical", file.path="character", make.blocking="logical"
a73cad91 (brodieG 2016-11-05 21:17:15 -0400 236)   ),
9b4e424c (brodieG 2016-05-07 20:45:37 -0400 237)   prototype=list(
8f28e201 (brodieG 2018-12-31 14:37:14 -0500 238)     pager=function(x) writeLines(readLines(x)), file.ext="", threshold=0L,
a73cad91 (brodieG 2016-11-05 21:17:15 -0400 239)     pager=function(x) stop("Pager object does not specify a paging function."),
98148365 (brodieG 2019-01-01 20:39:54 -0500 240)     ansi=FALSE, file.path=NA_character_, make.blocking=FALSE
413422ae (brodieG 2016-05-07 20:52:59 -0400 241)   ),

I'll add that to the list for the next release.

Is this causing you problems right now? Next release probably won't be for a while unless you actually have an immediate need for this being fixed. If so I can prioritize earlier.

[BillDunlap]

Thanks. No hurry, I just was taking another look at the package.

…

On Tue, Mar 19, 2019 at 2:42 PM Brodie Gaslam ***@***.***> wrote: Obviously this is an oversight. Thanks for reporting. Looking at the blame it appears that I intended the first one to be the new setting, and clearly failed to test for that properly. I'll add that to the list for the next release. Is this causing you problems right now? Next release probably won't be for a while unless you actually have an immediate need for this being fixed. If so I can prioritize earlier. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#132 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALHWBaUc_hsHaWPLiv_LQrDC_RX_LSL9ks5vYVnigaJpZM4b9Ifb> .

[brodieG]

This should be fixed on the development branch. Hope to send out to CRAN in the next week or two.

[brodieG]

Up on CRAN now.