-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repeated 'pager' entry in prototype for pager class #132
Comments
Obviously this is an oversight. Thanks for reporting. Looking at the blame it appears that I intended the first one to be the new setting, and clearly failed to test for that properly:
I'll add that to the list for the next release. Is this causing you problems right now? Next release probably won't be for a while unless you actually have an immediate need for this being fixed. If so I can prioritize earlier. |
Thanks. No hurry, I just was taking another look at the package.
…On Tue, Mar 19, 2019 at 2:42 PM Brodie Gaslam ***@***.***> wrote:
Obviously this is an oversight. Thanks for reporting. Looking at the blame
it appears that I intended the first one to be the new setting, and clearly
failed to test for that properly. I'll add that to the list for the next
release.
Is this causing you problems right now? Next release probably won't be for
a while unless you actually have an immediate need for this being fixed. If
so I can prioritize earlier.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#132 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALHWBaUc_hsHaWPLiv_LQrDC_RX_LSL9ks5vYVnigaJpZM4b9Ifb>
.
|
This should be fixed on the |
Up on CRAN now. |
In CRAN's diffobj-0.2.2 R/pager.R provides two 'pager' entries in the prototype for class 'Pager'. That seems wrong and one of them should be omitted. Currently the second, which calls stop(), is the one used, but it seems like the first would be a better default value.
The text was updated successfully, but these errors were encountered: