Error in match.call ... used in a situation where it does not exist

[noamross]

I get this hard-to-track error when I try to wrap a diffPrint (or any similar function) in another function and pass it dots:

library(diffobj)
fn <- function(target, current, ...) {
  diffPrint(target, current, ...)
}
fn("a", "b", format = "raw")
#> Error in match.call(definition = get.fun, call = found.call) : 
#>   ... used in a situation where it does not exist
#> < NULL       
#> > NULL       
#> @@ 1 / 1 @@  
#> < [1] "a"    
#> > [1] "b"

The especially weird part is that while the error prints, it does not stop execution - I get the diff object back. And it is an error - it does not go away if I suppress messages or warnings.

^{Created on 2019-04-21 by the reprex package (v0.2.1)}

Session info

devtools::session_info()
#> ─ Session info ──────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 3.5.3 (2019-03-11)
#>  os       macOS Mojave 10.14.3        
#>  system   x86_64, darwin15.6.0        
#>  ui       X11                         
#>  language (EN)                        
#>  collate  en_US.UTF-8                 
#>  ctype    en_US.UTF-8                 
#>  tz       America/New_York            
#>  date     2019-04-21                  
#> 
#> ─ Packages ──────────────────────────────────────────────────────────────
#>  package     * version    date       lib source                         
#>  assertthat    0.2.1      2019-03-21 [1] CRAN (R 3.5.1)                 
#>  backports     1.1.4      2019-04-10 [1] CRAN (R 3.5.2)                 
#>  callr         3.2.0      2019-03-15 [1] CRAN (R 3.5.2)                 
#>  cli           1.1.0      2019-03-19 [1] CRAN (R 3.5.2)                 
#>  crayon        1.3.4      2017-09-16 [1] CRAN (R 3.5.0)                 
#>  desc          1.2.0      2018-05-01 [1] CRAN (R 3.5.0)                 
#>  devtools      2.0.2      2019-04-08 [1] CRAN (R 3.5.2)                 
#>  diffobj     * 0.2.2      2019-03-15 [1] CRAN (R 3.5.2)                 
#>  digest        0.6.18     2018-10-10 [1] CRAN (R 3.5.0)                 
#>  evaluate      0.13       2019-02-12 [1] CRAN (R 3.5.2)                 
#>  fs            1.2.7      2019-03-19 [1] CRAN (R 3.5.1)                 
#>  glue          1.3.1      2019-03-12 [1] CRAN (R 3.5.1)                 
#>  highr         0.8        2019-03-20 [1] CRAN (R 3.5.1)                 
#>  htmltools     0.3.6      2017-04-28 [1] CRAN (R 3.5.0)                 
#>  knitr         1.22       2019-03-08 [1] CRAN (R 3.5.2)                 
#>  magrittr      1.5        2014-11-22 [1] CRAN (R 3.5.0)                 
#>  memoise       1.1.0.9000 2018-11-17 [1] Github (hadley/memoise@1650ad7)
#>  pkgbuild      1.0.3      2019-03-20 [1] CRAN (R 3.5.1)                 
#>  pkgload       1.0.2      2018-10-29 [1] CRAN (R 3.5.0)                 
#>  prettyunits   1.0.2      2015-07-13 [1] CRAN (R 3.5.0)                 
#>  processx      3.3.0      2019-03-10 [1] CRAN (R 3.5.2)                 
#>  ps            1.3.0      2018-12-21 [1] CRAN (R 3.5.0)                 
#>  R6            2.4.0      2019-02-14 [1] CRAN (R 3.5.1)                 
#>  Rcpp          1.0.1      2019-03-17 [1] CRAN (R 3.5.1)                 
#>  remotes       2.0.4      2019-04-10 [1] CRAN (R 3.5.2)                 
#>  rlang         0.3.4      2019-04-07 [1] CRAN (R 3.5.2)                 
#>  rmarkdown     1.12       2019-03-14 [1] CRAN (R 3.5.2)                 
#>  rprojroot     1.3-2      2018-01-03 [1] CRAN (R 3.5.0)                 
#>  sessioninfo   1.1.1      2018-11-05 [1] CRAN (R 3.5.0)                 
#>  stringi       1.4.3      2019-03-12 [1] CRAN (R 3.5.2)                 
#>  stringr       1.4.0      2019-02-10 [1] CRAN (R 3.5.2)                 
#>  testthat      2.0.1      2018-10-13 [1] CRAN (R 3.5.0)                 
#>  usethis       1.5.0      2019-04-07 [1] CRAN (R 3.5.2)                 
#>  withr         2.1.2      2018-03-15 [1] CRAN (R 3.5.0)                 
#>  xfun          0.6        2019-04-02 [1] CRAN (R 3.5.2)                 
#>  yaml          2.2.0      2018-07-25 [1] CRAN (R 3.5.0)                 
#> 
#> [1] /Library/Frameworks/R.framework/Versions/3.5/Resources/library

[brodieG]

Also a bug. The error is caught, but it doesn't have a subsequent diffobj level error that should happen, although this should all work fine in the first place. Problem is in extract_call.

Thanks for reporting with a reprex.

[brodieG]

This and #133 should be fixed on the development branch. Hope to send out to CRAN in the next week or two.

[noamross]

Thanks!