Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase with unstaged changes should have clear prompt #24

Open
avit opened this issue Apr 28, 2010 · 1 comment
Open

Rebase with unstaged changes should have clear prompt #24

avit opened this issue Apr 28, 2010 · 1 comment

Comments

@avit
Copy link

avit commented Apr 28, 2010

The rebase command shows an error dialog with the long, unformatted list of files when there are unstaged changes. The actual reason for the error is not shown clearly, except at the end of the raw command output, which can be hidden if there are many files.

The last line of the git command output says "cannot rebase: you have unstaged changes". This should be in the bold text of the error title, instead of the unclear "Rebase failed!"

The output of the git command with the list of unstaged files could be omitted by changing the dialog to use buttons:

  • Cancel (return to branch view)
  • Stage Files (default button: go to stage view)
@brotherbard
Copy link
Owner

Currently the error dialogs are generic and just show whatever git spits out. This was done to get things working quickly. Eventually I will go back and improve the messages but it's a pretty low priority at the moment.

kelan pushed a commit to kelan/gitx that referenced this issue May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants