styles: apply tailwind styles from Figma #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e379520): https://mmp-site-b1c9b--pr37-figma-styles-jhy9ro9x.web.app (expires Thu, 25 Apr 2024 13:51:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4eb870c89e876f1812e204af417359065d2a23b1 |
galenwinsor
reviewed
Apr 16, 2024
| <nav class="flex items-center justify-between"> | ||
| <h2 class="m-0 text-lg"><a class="text-black hover:text-gray-600 decoration-0" href="/">{SITE_TITLE}</a></h2> | ||
| <header> | ||
| <h2><a class="hover:text-gray-600 decoration-0" href="/">{SITE_TITLE}</a></h2> |
There was a problem hiding this comment.
What does decoration-0 do? Doesn't that just remove the underline? In that case, you could use no-underline
There was a problem hiding this comment.
Yes, you are correct! Looks like this is leftover from the blog post defaults-- not sure why they didn't use no-underline. Changing now~
galenwinsor
reviewed
Apr 16, 2024
galenwinsor
reviewed
Apr 16, 2024
| <head> | ||
| <BaseHead title={SITE_TITLE} description={SITE_DESCRIPTION} /> | ||
| </head> | ||
| <body class="single-column"> |
There was a problem hiding this comment.
I imagine this should be in a layout component?
There was a problem hiding this comment.
Yes, let's plan on a refactor in a different PR
galenwinsor
reviewed
Apr 16, 2024
| padding: 1em; | ||
| } | ||
| } | ||
| @import url("https://use.typekit.net/jng2int.css"); |
galenwinsor
suggested changes
Apr 16, 2024
Co-authored-by: Galen Winsor <57297033+galenwinsor@users.noreply.github.com>
galenwinsor
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to update styles to match the Figma design system.
Files Changed
global.css: this is where we standardize html elements and classes used throughout the app; we@applystyles defined intailwind.config.jstailwind.config.js: created by runningnpx tailwind init --full. Within here we chose to override tailwind's default colors and box-shadowBlogPost.astro: remove style scriptindex.astro: remove classes from elements so that we can view our changes from global.cssBaseHead.astro: remove preloaded fontsHeader.astro: remove classes from elements so that we can view our changes from global.cssFiles Removed
Font files from default astro
Refs
Figma Design System
Tailwind Custom Styles Docs