Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use libCST's native parser #574

Merged
merged 1 commit into from
Apr 11, 2022
Merged

feat: use libCST's native parser #574

merged 1 commit into from
Apr 11, 2022

Conversation

browniebroke
Copy link
Owner

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 11, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.17%.

Quality metrics Before After Change
Complexity 1.51 ⭐ 1.49 ⭐ -0.02 👍
Method Length 38.50 ⭐ 37.95 ⭐ -0.55 👍
Working memory 6.17 ⭐ 6.14 ⭐ -0.03 👍
Quality 83.77% 83.94% 0.17% 👍
Other metrics Before After Change
Lines 397 404 7
Changed files Quality Before Quality After Quality Change
src/django_codemod/cli.py 77.65% ⭐ 77.69% ⭐ 0.04% 👍
tests/test_cli.py 90.17% ⭐ 90.39% ⭐ 0.22% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/django_codemod/cli.py run 4 ⭐ 167 😞 18 ⛔ 46.38% 😞 Try splitting into smaller methods. Extract out complex expressions
src/django_codemod/cli.py VersionParamType._parse_unsafe 1 ⭐ 57 ⭐ 10 😞 74.38% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #574 (934a382) into main (a26184b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   98.63%   98.64%           
=======================================
  Files          30       30           
  Lines        1028     1030    +2     
  Branches      196      196           
=======================================
+ Hits         1014     1016    +2     
  Partials       14       14           
Impacted Files Coverage Δ
src/django_codemod/cli.py 99.18% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26184b...934a382. Read the comment docs.

@browniebroke browniebroke merged commit d16eb50 into main Apr 11, 2022
@browniebroke browniebroke deleted the feat/native-parser branch April 11, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant