Skip to content

Conversation

asolove
Copy link
Contributor

@asolove asolove commented Feb 10, 2024

Resolves #350.

Before After
image image
  • Rename modal's submit button now says Rename
  • All modal cancel buttons have blue, rather than gray, text, to show they are clickable and to match Google styles.

In the initial issue, @shriram asked:

I also feel like the very light grey of Cancel makes it looks like it's not enabled. Is the grey instead of red for cancel a consistent style?

I agree that the light gray only makes it look not enabled. This PR makes the text blue to match the styles commonly used in the Google/Chromebook apps that students will be familiar with. e.g. here is a sample from Google Docs:

image

In general, I'd recommend we not use red for non-destructive secondary actions like "close", as it has a connotation of something dangerous, whereas in this case close should clearly be taken as the neutral action with no side-effects. CPO no longer uses red for any secondary actions that I can find from clicking around.

- Rename modal's submit button now says Rename
- All modal cancel buttons have blue, rather than gray, text, to show they are clickable and to match Google styles.
@shriram
Copy link
Member

shriram commented Feb 11, 2024 via email

@jpolitz
Copy link
Member

jpolitz commented Feb 12, 2024

Looks good thanks!

@jpolitz jpolitz merged commit 0202721 into brownplt:horizon Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better labels
3 participants