Improve styling of Rename modal and modal cancel buttons. #509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #350.
In the initial issue, @shriram asked:
I agree that the light gray only makes it look not enabled. This PR makes the text blue to match the styles commonly used in the Google/Chromebook apps that students will be familiar with. e.g. here is a sample from Google Docs:
In general, I'd recommend we not use red for non-destructive secondary actions like "close", as it has a connotation of something dangerous, whereas in this case close should clearly be taken as the neutral action with no side-effects. CPO no longer uses red for any secondary actions that I can find from clicking around.