-
Notifications
You must be signed in to change notification settings - Fork 32
redo region routing #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
fe3eb44
update urls, ts ignore fix (#8)
Kylejeong2 112981f
feat: add query param parsing (#9)
Kylejeong2 2f906d3
disable captcha solving if query params are passed in (#10)
Kylejeong2 edf39f2
update model tag (#12)
miguelg719 fd6bf8b
redo region routing
sameelarif 958d8c8
small updates
miguelg719 1fae745
changes
miguelg719 dc7bd03
render last reasoning
miguelg719 c76cd19
add sdk to repo
miguelg719 3200b83
adding stagehand package to next config
Kylejeong2 14f392f
update tailwind config ts ignore and exclude sdk from build process
Kylejeong2 cf2346a
updated sdk
miguelg719 96c4acf
probability based region routing (#13)
sameelarif face517
Revert "probability based region routing (#13)"
sameelarif 1820eef
no inline import
sameelarif 4620227
redo region routing
sameelarif 11cc5b1
add suspense wrapper to home component for search params
Kylejeong2 f3d9381
pull from edge config
sameelarif 9da2e38
Merge branch 'sameel/flags-new' into sameel/edge-config
sameelarif 880651a
Merge branch 'main' into sameel/edge-config
sameelarif 381115f
fix imports
sameelarif b45306d
Merge branch 'sameel/flags-new' of https://github.com/browserbase/pri…
sameelarif 968f315
Merge branch 'sameel/flags-new' into sameel/edge-config
sameelarif 33a83eb
Merge pull request #15 from browserbase/sameel/edge-config
sameelarif 3cab49b
pull region dist. from edge config
sameelarif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,3 +84,4 @@ target/ | |
|
||
test/ | ||
.vercel | ||
.env*.local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timezone region mapping is completely broken - the client sends timezone identifiers like "America/New_York" but the server now expects timezone abbreviations like "EST". This will cause all sessions to default to "us-west-2" regardless of user location.
View Details
📝 Patch Details
Analysis
Timezone region mapping broken for IANA identifiers in session creation
What fails: getRegionFromTimezoneAbbr() only handles timezone abbreviations like "EST" but client sends IANA timezone identifiers like "America/New_York", causing all sessions to default to "us-west-2"
How to reproduce:
Result: All users with IANA timezone identifiers (default browser behavior) get routed to us-west-2 instead of their geographic region
Expected: "America/New_York" should map to "us-east-1", "Europe/London" to "eu-central-1", per Intl.DateTimeFormat docs which return IANA timezone names