edge config for browser settings #15
Merged
+51
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| console.log("timezone ", timezone); | ||
| console.log("getClosestRegion(timezone)", getClosestRegion(timezone)); | ||
| const config = await getAll<EdgeConfig>(); |
There was a problem hiding this comment.
Suggested change
| const config = await getAll<EdgeConfig>(); | |
| let config: EdgeConfig; | |
| try { | |
| config = await getAll<EdgeConfig>(); | |
| } catch (error) { | |
| console.warn('Edge Config unavailable, using defaults:', error); | |
| config = { advancedStealth: undefined, proxies: undefined }; | |
| } |
The getAll<EdgeConfig>() call may throw an error when the Edge Config is not set up or accessible, but this error is not caught and will cause the entire session creation to fail.
View Details
Analysis
Unhandled Edge Config error breaks session creation API
What fails: createSession() in app/api/session/route.ts calls getAll<EdgeConfig>() without error handling, causing 500 errors when Edge Config is not configured
How to reproduce:
# Without EDGE_CONFIG environment variable set:
curl -X POST http://localhost:3000/api/session -H "Content-Type: application/json" -d '{"timezone":"PST"}'Result: Returns 500 Internal Server Error with message "@vercel/edge-config: No connection string provided"
Expected: Should return 200 OK with session data, using default values (advancedStealth: false, proxies: true) when Edge Config is unavailable per Vercel Edge Config SDK docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.