updates for BB-820: first crack #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BB-820 Review Python Client + ensure forwards/backwards compatibility
TODO:
BB-924 Types update Python SDK
Add updated types (might be missing last minute updates), fix closing session (call api |
kamath
reviewed
Feb 26, 2025
examples/example.py
Outdated
| print("Navigation complete with local Playwright.") | ||
|
|
||
| await stagehand.page.navigate("https://www.google.com") | ||
| await page.navigate("https://www.google.com") |
stagehand/client.py
Outdated
Comment on lines
219
to
232
| # if self._playwright_page: | ||
| # self._log("Closing the Playwright page...", level=1) | ||
| # await self._playwright_page.close() | ||
| # self._playwright_page = None | ||
|
|
||
| if self._context: | ||
| self._log("Closing the context...", level=1) | ||
| await self._context.close() | ||
| self._context = None | ||
| # if self._context: | ||
| # self._log("Closing the context...", level=1) | ||
| # await self._context.close() | ||
| # self._context = None | ||
|
|
||
| if self._browser: | ||
| self._log("Closing the browser...", level=1) | ||
| await self._browser.close() | ||
| self._browser = None | ||
| # if self._browser: | ||
| # self._log("Closing the browser...", level=1) | ||
| # await self._browser.close() | ||
| # self._browser = None |
| except json.JSONDecodeError: | ||
| self._log(f"Could not parse line as JSON: {line}", level=2) | ||
| continue | ||
| try: |
There was a problem hiding this comment.
clean up where unnecessary, avoid print statements and use logger instead
| browserbase_session_id (Optional[str]): Session ID for resuming Browserbase sessions. | ||
| model_name (Optional[str]): Name of the model to use. | ||
| model_client_options (Optional[Dict[str, Any]]): Configuration options for the model client. | ||
| selfHeal (Optional[bool]): Enable self-healing functionality. |
stagehand/config.py
Outdated
| model_name: Optional[str] = Field(None, alias="modelName", description="Name of the model to use") | ||
| model_client_options: Optional[Dict[str, Any]] = Field(default_factory=dict, alias="modelClientOptions", description="Options for the model client") | ||
| model_name: Optional[str] = Field(AvailableModel.GPT_4O, alias="modelName", description="Name of the model to use") | ||
| selfHeal: Optional[bool] = Field(True, description="Enable self-healing functionality") |
stagehand/schemas.py
Outdated
| action: str = Field(..., description="The action command to be executed by the AI.") | ||
| useVision: Optional[Union[bool, str]] = None | ||
| variables: Optional[Dict[str, str]] = None | ||
| modelName: Optional[AvailableModel] = None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.