Skip to content

Conversation

miguelg719
Copy link
Collaborator

Added linting checks, and auto CI for building, testing (not evals yet) and publishing to pypi

Copy link

linear bot commented Feb 27, 2025

BB-928 Python SDK CI

Very much needed. Linting + PyPi ( + evals? )

@filip-michalsky filip-michalsky self-requested a review March 6, 2025 15:38
Copy link
Collaborator

@filip-michalsky filip-michalsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - just need to check the trigger of the workflow on GH CI - first, need someone's pypi user creds...


# Auto-fix issues where possible
ruff check --fix .
ruff format .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently get lots of issues running this locally? meaning, many type issues

@@ -0,0 +1,12 @@
[bumpversion]
current_version = 0.3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea 0.3 makes sense

Before using the publishing workflow, ensure you have:

1. Set up the following secrets in your GitHub repository settings:
- `PYPI_USERNAME`: Your PyPI username
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don;'t think I have the access rights to set these, and would likely not want my pypi account in the secrets for this repo anyway - you want me to create a new one? or idk

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should def set up a browserbase account for this

@miguelg719 miguelg719 merged commit 5b90b7b into main Mar 10, 2025
@filip-michalsky filip-michalsky deleted the miguel/bb-928-python-sdk-ci branch March 11, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants