fixed snake_case migration #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BB-955 Fix snake_case migration on Python
Requests are now snake case, but this is causing an issue in the body for the API request where it expects camelCase. |
filip-michalsky
approved these changes
Mar 3, 2025
| ..., description="Instruction specifying what data to extract using AI." | ||
| ) | ||
| model_name: Optional[AvailableModel] = Field(None, alias="modelName") | ||
| model_name: Optional[AvailableModel] = None |
There was a problem hiding this comment.
is the model name really optional?
There was a problem hiding this comment.
yes there's a default in config
| """Serialize schema_definition to a JSON schema if it's a Pydantic model""" | ||
| if isinstance(schema_definition, type) and issubclass(schema_definition, BaseModel): | ||
| return schema_definition.model_json_schema() | ||
| return schema_definition |
There was a problem hiding this comment.
do you have a test for it?
There was a problem hiding this comment.
smoke tested locally w/ example.py:
class News(BaseModel):
description: str
url: str
...
data = await page.extract(ExtractOptions(
instruction="extract the first result from the search",
schema_definition=News,
))There was a problem hiding this comment.
awesome, confirming it works for me as well!
|
LGTM - just need to test the schema serializer for extract and confirm it works |
filip-michalsky
approved these changes
Mar 4, 2025
|
feel free to merge this :) |
filip-michalsky
deleted the
miguel/bb-955-fix-snake_case-migration-on-python
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.