Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-walls-walk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@browserbasehq/stagehand-lib": patch
---

Fixed small issue with module-level state guard for the Playwright selectors.register call
23 changes: 15 additions & 8 deletions lib/StagehandPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ async function getCurrentRootFrameId(session: CDPSession): Promise<string> {
return frameTree.frame.id;
}

/** ensure we register the custom selector only once per process */
let stagehandSelectorRegistered = false;

export class StagehandPage {
private stagehand: Stagehand;
private rawPage: PlaywrightPage;
Expand Down Expand Up @@ -197,10 +194,7 @@ ${scriptContent} \

/** Register the custom selector engine that pierces open/closed shadow roots. */
private async ensureStagehandSelectorEngine(): Promise<void> {
if (stagehandSelectorRegistered) return;
stagehandSelectorRegistered = true;

await selectors.register("stagehand", () => {
const registerFn = () => {
type Backdoor = {
getClosedRoot?: (host: Element) => ShadowRoot | undefined;
};
Expand Down Expand Up @@ -299,7 +293,20 @@ ${scriptContent} \
return out;
},
};
});
};

try {
await selectors.register("stagehand", registerFn);
} catch (err) {
if (
err instanceof Error &&
err.message.match(/selector engine has been already registered/)
) {
// ignore
} else {
throw err;
}
}
}

/**
Expand Down
Loading