Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support res.setEncoding and non-text response types #21

Open
wmrowan opened this issue Jul 22, 2013 · 6 comments
Open

Support res.setEncoding and non-text response types #21

wmrowan opened this issue Jul 22, 2013 · 6 comments

Comments

@wmrowan
Copy link

@wmrowan wmrowan commented Jul 22, 2013

Response data in http-browserify seems to default to text. In node http it seems to default to buffer. Independent of defaults, the node version supports setEncoding so you can change the type of the response. The browserify version should do the same.

@Jxck
Copy link

@Jxck Jxck commented Sep 9, 2014

+1
or support only setEncoding('utf8') and ignore others seems fine.

@tellnes
Copy link
Contributor

@tellnes tellnes commented Sep 9, 2014

See #10

@MiguelCastillo
Copy link

@MiguelCastillo MiguelCastillo commented Sep 9, 2014

So, is there a plan to merge the PR?

@jamestalmage
Copy link

@jamestalmage jamestalmage commented Jun 30, 2015

Would there be any value to throwing or at least logging an error if it is not utf-8?

+1 either way.

jamestalmage added a commit to jamestalmage/node-github that referenced this issue Jun 30, 2015
The main issue preventing browserify usage was computed paths
in require statements: `require("./" + someVariable)`. Those have
all been eliminated.

This patch only adds browser support for `v3.0.0` (see the throwing
code in `/index.js` where it states exactly that to understand why).
Hint: it's related to computed paths again.

There were also a number of issues in `browserify-http`, and
`browserify-https` that I needed to code around to get things working:

  - substack/https-browserify#1
  - browserify/http-browserify#90
  - browserify/http-browserify#21
  - browserify/http-browserify#10
@jstoeffler
Copy link

@jstoeffler jstoeffler commented Apr 17, 2016

+1

@drawm
Copy link

@drawm drawm commented Sep 23, 2016

+1
Causes problem on other library.
baalexander/node-xmlrpc#135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants