Skip to content

drop Node <4 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2017
Merged

drop Node <4 #46

merged 1 commit into from
May 24, 2017

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented May 24, 2017 •
edited
Loading

Resolves the test failures, as even safe-buffer doesn't handle <4 (afaik)

@dcousens dcousens self-assigned this May 24, 2017
@dcousens dcousens requested review from dominictarr and fanatid May 24, 2017 06:34
@fanatid
Copy link
Contributor

fanatid commented May 24, 2017

you decide add safe-buffer everywhere? 😃

@dcousens dcousens merged commit 1c879cf into master May 24, 2017
@dcousens dcousens deleted the no012 branch May 24, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominictarr dominictarr Awaiting requested review from dominictarr

1 more reviewer

@fanatid fanatid fanatid approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dcousens dcousens

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcousens @fanatid