Fix a bug in the sandbox breakout fix #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `return FAIL` was making the anonymous function of the forEach call to return, that wasn't what I was expecting, so the last fix didn't have any effects. I changed the code so now the `return FAIL` makes the main function return.
Closed
|
Any updates/ETA? |
This was referenced Jul 16, 2019
This was referenced Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
return FAILwas making the anonymous function of the forEach callto return. That wasn't what I was expecting, so the last fix didn't have
any effects. I changed the code so now the
return FAILmakes the mainfunction return.
This time I tested the fix, and it is working properly.