Enable Safari 10 save mangling #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari 10 has an issue with `let` and redeclarations; the only way to safely let uglify mangle and generate a build capable of supporting Safari 10 is to enable the specific Safari 10 option. No. Seriously. mishoo/UglifyJS#1753 (comment) There is no noticable bundle size difference with this enabled | type | safari10: true | safari10: false| ----------------------------------------- | uncompressed | 494k | 489k | | brotli | 130k | 134k | | gzip | 154k | 148k | | deflate | 154k | 148k | So somehow this is making Brotli more efficient. And the only browser that doesn't support Brotli? Safari 10. So win-win everywhere!
|
wuh. that should be the default option. oh well. thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari 10 has an issue with
letand redeclarations; the only way to safelylet uglify mangle and generate a build capable of supporting Safari 10 is to
enable the specific Safari 10 option.
No.
Seriously.
mishoo/UglifyJS#1753 (comment)
There is no noticable bundle size difference with this enabled
So somehow this is making Brotli more efficient. And the only browser that
doesn't support Brotli? Safari 10.
So win-win everywhere!