Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable headless key in run_settings #103

Merged
merged 4 commits into from
Feb 1, 2021
Merged

Enable headless key in run_settings #103

merged 4 commits into from
Feb 1, 2021

Conversation

suryart
Copy link
Collaborator

@suryart suryart commented Jan 4, 2021

This PR enables the headless key to disable running browsers in headless mode on BrowserStack.

  • When headless key is set to false or "false" it disabled the headless mode.
  • When headless key is not provided or set to anything other than false or "false" it runs the tests in headless mode.
  • Added --headed option to the run command which defaults to true and sets headless key as false.

@karanshah-browserstack
Copy link
Collaborator

Should we also update the default browserstack.json so users are aware of this option?

@prateekbstack
Copy link
Collaborator

LGTM

@suryart suryart merged commit 76d069a into master Feb 1, 2021
@suryart suryart deleted the headless-browsers branch February 1, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants