Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update async whilst syntax #112

Merged
merged 2 commits into from
Feb 15, 2021
Merged

fix: Update async whilst syntax #112

merged 2 commits into from
Feb 15, 2021

Conversation

SagarGaniga
Copy link
Collaborator

@SagarGaniga SagarGaniga commented Feb 11, 2021 •
edited
Loading

--sync was failing because of the structural change in async.whilst

ref:

  1. https://stackoverflow.com/a/15393337/8266093
  2. https://caolan.github.io/async/v3/docs.html#whilst

@prateekbstack
Copy link
Collaborator

LGTM

@suryart suryart merged commit 2a09083 into master Feb 15, 2021
@suryart suryart deleted the async_whilst_syntax_change branch February 15, 2021 06:03
@suryart suryart mentioned this pull request Feb 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryart suryart suryart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SagarGaniga @prateekbstack @suryart