error shown if username or password not given #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karanshah-browserstack
requested changes
Mar 3, 2021
bin/helpers/capabilityHelper.js
Outdated
| @@ -132,6 +132,14 @@ const validate = (bsConfig, args) => { | |||
| // if parallels specified via arguments validate only arguments | |||
| if (!Utils.isUndefined(args) && !Utils.isUndefined(args.parallels) && !Utils.isParallelValid(args.parallels)) reject(Constants.validationMessages.INVALID_PARALLELS_CONFIGURATION); | |||
|
|
|||
| if(!Utils.isUndefined(args)){ | |||
| if(!Utils.isUndefined(args.username) && !Utils.isUndefined(args.key)) | |||
There was a problem hiding this comment.
What if I don't provide "" in args and set it in browserstack.json. Please consider that case too.
Also, can you move this validation a bit up? where we already have validation for username and password? https://github.com/browserstack/browserstack-cypress-cli/pull/118/files#diff-26dee8fe62c5e891965d2de49dd74bd0fad786ae2544889d5519d222a6145256R119
karanshah-browserstack
requested changes
Mar 3, 2021
karanshah-browserstack
approved these changes
Mar 3, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user enters empty password or username then error is thrown during validation