Add warning around spec count #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryart
requested changes
Mar 16, 2021
bin/helpers/utils.js
Outdated
| @@ -148,6 +148,24 @@ exports.setParallels = (bsConfig, args, numOfSpecs) => { | |||
| } | |||
| }; | |||
|
|
|||
| exports.warnSpecLimit = (bsConfig, args, specFiles) => { | |||
| let expectedCharLength = specFiles.join("").length + 175 * specFiles.length; | |||
There was a problem hiding this comment.
What's 175? Can we name it? Maybe from use it from a constant?
bin/helpers/utils.js
Outdated
| @@ -148,6 +148,24 @@ exports.setParallels = (bsConfig, args, numOfSpecs) => { | |||
| } | |||
| }; | |||
|
|
|||
| exports.warnSpecLimit = (bsConfig, args, specFiles) => { | |||
| let expectedCharLength = specFiles.join("").length + 175 * specFiles.length; | |||
| let parallels = bsConfig['run_settings']['parallels']; | |||
There was a problem hiding this comment.
let's use the . instead: bsConfig.run_settings.parallels.
bin/helpers/utils.js
Outdated
| let parallels = bsConfig['run_settings']['parallels']; | ||
| let combinations = this.getBrowserCombinations(bsConfig).length; | ||
| let parallelPerCombination = parallels > combinations ? Math.floor(parallels / combinations) : 1 | ||
| let expectedCharLengthPerParallel = expectedCharLength / parallelPerCombination |
There was a problem hiding this comment.
semicolon? Also, can we ensure that this is going to be an INT and not float?
suryart
previously approved these changes
Mar 16, 2021
bin/helpers/constants.js
Outdated
| @@ -40,7 +40,8 @@ const userMessages = { | |||
| CYPRESS_VERSION_CHANGED: "Your build will run using Cypress <actualVersion> instead of Cypress <preferredVersion>. Read more about supported versions here: http://browserstack.com/docs/automate/cypress/supported-versions", | |||
| LOCAL_START_FAILED: "Local Testing setup failed.", | |||
| LOCAL_STOP_FAILED: "Local Binary stop failed.", | |||
| INVALID_LOCAL_MODE_WARNING: "Invalid value specified for local_mode. local_mode: (\"always-on\" | \"on-demand\"). For more info, check out https://www.browserstack.com/docs/automate/cypress/cli-reference" | |||
| INVALID_LOCAL_MODE_WARNING: "Invalid value specified for local_mode. local_mode: (\"always-on\" | \"on-demand\"). For more info, check out https://www.browserstack.com/docs/automate/cypress/cli-reference", | |||
| SPEC_LIMIT_WARNING: "There is a chance that you might not see all the results on the dashboard because of your spec count." | |||
There was a problem hiding this comment.
You might not see all your results on the dashboard because of high spec count, please consider reducing the number of spec files in this folder.
suryart
approved these changes
Mar 17, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add warning around a number of spec files in the given build for individual parallel.