Cyp 372 env var #48
Merged
Cyp 372 env var #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,3 +131,8 @@ exports.exportResults = (buildId, buildUrl) => { | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| exports.deleteResults = () => { | |||
| fs.unlink("log/build_results.txt", function (err){ | |||
There was a problem hiding this comment.
add log line for error?
There was a problem hiding this comment.
The unlink function throws an error even if there is no file present in the directory. And it is a validate case. Hence haven't logged any error.
nagpalkaran95
previously approved these changes
Sep 1, 2020
…-cli into CYP_372_ENV_VAR
nagpalkaran95
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting BUILD_ID & BUILD_URL to build_results.txt