Skip to content

Conversation

gpittarelli
Copy link

@gpittarelli gpittarelli commented Jun 20, 2018

sinon and temp-fs are only used in test code; so they should be in devDependencies to make installs of this module a bit lighter.

Particularly annoying since this version of sinon pulls in an old version of the util library... which seems to take precedence over the builtin util module in some situations 😖

Travis failure seems to be due to a missing BROWSERSTACK_ACCESS_KEY; providing one gets npm test to pass for me.

@gpittarelli gpittarelli force-pushed the gjp/package-json-cleanup branch from 6b98eb4 to 846a99a Compare June 20, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant