Skip to content

Add context manager to Local #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Add context manager to Local #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions browserstack/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
from browserstack.bserrors import BrowserStackLocalError

class Local:
def __init__(self, key=None, binary_path=None):
def __init__(self, key=None, binary_path=None, **kwargs):
self.key = os.environ['BROWSERSTACK_ACCESS_KEY'] if 'BROWSERSTACK_ACCESS_KEY' in os.environ else key
self.options = None
self.options = kwargs
self.local_logfile_path = os.path.join(os.getcwd(), 'local.log')

def __xstr(self, key, value):
Expand All @@ -29,7 +29,8 @@ def _generate_stop_cmd(self):
return cmd

def start(self, **kwargs):
self.options = kwargs
for k, v in kwargs.items():
self.options[k] = v

if 'key' in self.options:
self.key = self.options['key']
Expand Down Expand Up @@ -74,3 +75,10 @@ def stop(self):
(out, err) = proc.communicate()
except Exception as e:
return

def __enter__(self):
self.start(**self.options)
return self

def __exit__(self, *args):
self.stop()
4 changes: 4 additions & 0 deletions tests/test_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,7 @@ def test_local_identifier(self):
self.local.start(localIdentifier='mytunnel', onlyCommand=True)
self.assertIn('-localIdentifier', self.local._generate_cmd())
self.assertIn('mytunnel', self.local._generate_cmd())

def test_context_manager(self):
with Local('BROWSERSTACK_ACCESS_KEY') as local:
self.assertNotEqual(local.proc.pid, 0)