Skip to content

Retry URL Fixes #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2015
Merged

Retry URL Fixes #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions bin/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,8 @@ function attachWorkerHelpers(worker) {
// TODO: Consider creating instances of a proper 'Worker' class

worker.buildUrl = function buildUrl(test_path) {
return buildTestUrl(test_path || this.test_path, this._worker_key, this.getTestBrowserInfo());
var workerKey = workerKeys[this.id] ? workerKeys[this.id].key : null;
return buildTestUrl(test_path || this.test_path, workerKey, this.getTestBrowserInfo());
};

worker.getTestBrowserInfo = function getTestBrowserInfo(test_path) {
Expand Down Expand Up @@ -287,7 +288,7 @@ var statusPoller = {
worker.awaitAck();

worker.activityTimeout = setTimeout(function () {
if (!worker.acknowledged) {
if (!worker.isAckd) {
var subject = 'Worker inactive for too long: ' + worker.string;
var content = 'Worker details:\n' + JSON.stringify(worker.config, null, 4);
utils.alertBrowserStack(subject, content, null, function(){});
Expand All @@ -308,7 +309,7 @@ var statusPoller = {
}, activityTimeout * 1000);

worker.testActivityTimeout = setTimeout(function () {
if (worker.acknowledged) {
if (worker.isAckd) {
var subject = 'Tests timed out on: ' + worker.string;
var content = 'Worker details:\n' + JSON.stringify(worker.config, null, 4);
utils.alertBrowserStack(subject, content, null, function(){});
Expand Down