Fix for failing Travis builds #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
Thanks! |
shirish87
added a commit
that referenced
this pull request
Aug 21, 2015
Local: Fix for failing Travis builds Now passing localIdentifier arg to child_process.execFile as a separate array element instead of string concat. Fixes #102.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In environments like Travis, the
-localIdentifieroption is set for theBrowserStackLocalbinary used for creating the local tunnel.For some inexplicable reason, child_process.execFile seems to require each args array element to be an independent fragment of the command - for e.g. [ '-localIdentifier ' + 'ID:1' ] vs. [ '-localIdentifier', 'ID:1' ]. I have no idea why it works that way.
Working Travis Build with the fix.
Thanks, @TehShrike and @ausi for helping out.
Fixes #102.