Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tunnel_pid and test_server_port settings #180

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Add tunnel_pid and test_server_port settings #180

merged 1 commit into from
Dec 7, 2017

Conversation

eugenet8k
Copy link
Contributor

@eugenet8k eugenet8k commented Jul 5, 2017 •
edited

  • Add support of config.tunnel_pid and cli —pid param
    • It should be a string with a filename to save process id
    • It will allow external process to control the tunnel process
    • If automated jobs for browserstack hanged or shutdown, we want to kill previous tunnel process manually before starting tests again.
  • Add support of config.test_server_port param

@eugenet8k eugenet8k changed the title Add pid cli param for tunnel process Add tunnel_pid and test_server_port settings Jul 6, 2017
@pulkitsharma07 pulkitsharma07 requested review from jzaefferer and removed request for jzaefferer July 7, 2017 19:38
@eugenet8k
Add tunnel_pid and test_server_port settings
064f0e9 
* Add support of `config.tunnel_pid` and cli `—pid` param
  - It should be a string like “/dir1/dir2/file.pid” to save process id
  - It will allow external process to control the tunnel process
  - If automated jobs for browserstack hanged or shutdown, we want to kill previous tunnel process manually before starting tests again.
* Add support of `config.test_server_port` param
  - If not set, the default 8888 port is used
  - List of support ports: https://www.browserstack.com/question/664
@pulkitsharma07
Copy link
Contributor

@eugenet8k please merge the latest master.

@eugenet8k
Copy link
Contributor Author

@pulkitsharma07 will do, thanks for your attention to this PR.

@pulkitsharma07 pulkitsharma07 mentioned this pull request Dec 7, 2017
Merged
@pulkitsharma07 pulkitsharma07 merged commit 064f0e9 into browserstack:master Dec 7, 2017
pulkitsharma07 added a commit that referenced this pull request Dec 7, 2017
@pulkitsharma07
Merge pull request #193 from browserstack/lookout-add-pid-cli-param
c941e04 
Sanitizing #180
@pulkitsharma07
Copy link
Contributor

Not needed any more 👍

@eugenet8k eugenet8k deleted the add-pid-cli-param branch December 7, 2017 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pulkitsharma07 pulkitsharma07 pulkitsharma07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eugenet8k @pulkitsharma07