Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conditional tag matching logic everywhere #190

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

cwisecarver
Copy link
Contributor

The logic to match a tag depending on test framework was not consistent when using the test_server configuration option. It would always search for </head> and replace that with </body> if the framework was not mocha. This PR puts that logic into a function and uses it in both places.

@cwisecarver
Copy link
Contributor Author

@pulkitsharma07 Updated to merge cleanly.

@francisf francisf merged commit fb33f8e into browserstack:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants