Modified repo structure for Junit 4 & 5 #29
Conversation
|
@francisf - kindly review |
| public class MarkSessionStatus { | ||
| public void markTestStatus(String status, String reason, WebDriver driver){ | ||
| JavascriptExecutor jse = (JavascriptExecutor) driver; | ||
| jse.executeScript("browserstack_executor: {\"action\": \"setSessionStatus\", \"arguments\": {\"status\": \""+ status + "\", \"reason\": \"" + reason + "\"}}"); |
There was a problem hiding this comment.
Possible to use a hashmap instead?
{\"action\": \"setSessionStatus\", \"arguments\": {\"status\": \""+ status + "\", \"reason\": \"" + reason + "\"}}"
There was a problem hiding this comment.
Should I replace the JSE inputs with a hashmap? Need more details on the requirement.
There was a problem hiding this comment.
i meant a json object, providing a direct string is making this difficult to read. we can later convert it from object to string
There was a problem hiding this comment.
The syntax used is to keep it simple and inline with our docs.
There was a problem hiding this comment.
Using REST API instead of JSE
|
|
||
| //@WebDriverTest | ||
| void googleTest(WebDriver driver) { | ||
| driver.get("https://google.com/"); |
There was a problem hiding this comment.
changed to bstackdemo.com
| final String product_in_cart = wait.until(ExpectedConditions.visibilityOfElementLocated(By.xpath("//*[@id=\'__next\']/div/div/div[2]/div[2]/div[2]/div/div[3]/p[1]"))).getText(); | ||
| if (product_name.equals(product_in_cart)) { | ||
| sessionStatus.markTestStatus("passed", "Product has been successfully added to the cart!",driver); | ||
| }else{ |
| sessionStatus.markTestStatus("passed", "Local content validated!",driver); | ||
| else | ||
| sessionStatus.markTestStatus("failed", "Local content not validated!",driver); | ||
| }catch (Exception e){ |
| } | ||
| accesskey = System.getenv("BROWSERSTACK_ACCESS_KEY"); | ||
| if(accesskey == null){ | ||
| accesskey = (String) mainConfig.get("accesskey"); |
There was a problem hiding this comment.
accessKey = (String) config.get("key"); this was used for sel4, can we keep all the variable names and keys same?
There was a problem hiding this comment.
have modified the variable names to "key" and "user" as per the capabilities doc for Selenium 3
junit-5/pom.xml
Outdated
| </build> | ||
| </profile> | ||
| </profiles> | ||
| </project> |
| { | ||
| "browser": "Internet Explorer" | ||
| }, |
There was a problem hiding this comment.
please confirm if bstackdemo works on IE across win versions. Similar issue faced somewhere else
Updates in repo:
Junit 4 changes: