Git diff command to track all changes, not only cached!

[squirrelito]

I am finding this as improvement because otherwise if you do commit -a -m "etc" will not stage the modifications before the hook and will not verify contents of the modified files.

[bruli]

Travis build is broken. Please fix it.

[squirrelito]

Just closed and reopened the PR ... travis broke for some reason marking it as failed build ... all fine now.

The intention here is the following:
I may be wrong or not (probably I do not have the in-depth knowledge about git) but here is what ...
I am committing my changes from PhpStorm which obviously succeeds to git add and commit (not sure if it uses git commit -a -m "etc") while the pre-commit hook doesn't catch the modified but not yet added to the index files and so the hook doesn't execute fixers, phpunit and so on against them.

The change is resulting in a slightly slower exec("git diff --name-only $against", $this->output); but it is working correctly when triggering commit from PhpStorm (haven't tested other GUI git clients like Source Tree etc).

[bruli]

I think that I not understand this.

It's a new hook?. In this case, what hook?.

[squirrelito]

Well, I will try to explain in less lines :)
ExtractCommitedFiles.php would use git diff-index --cached --name-status which would miss changed files when doing git commit -a -m "etc" resulting in no checks against the modified files.
Setting it like git diff --name-only would solve this.

My setup is to use PhpStorm's git client in order to commit and push to a git repo which probably does -a -m for the modified files.