This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
Upgrade node-sass to 4.5.3 #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulmillr Any updates on this PR? |
|
I've tested this on Windows 10 x64, and it fixes #151 for me. I will run off the fork until this gets merged, but it would be great if it could be done soon. |
|
v2.10.5 is out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #146 using Node 7.2.1 on Ubuntu. All tests in test.js passed successfully. I tested the sample repo in #141 (https://github.com/paulmillr/sass-test) and sass-brunch worked w/o issues. In addition, running
brunch build --production(with a few SASS styles and 1 partial) did not produce any issues. Using an ampersand (&) rule also worked correctly.@paulmillr mentioned that the latest version of node-sass at the time (4.5.0) broke sass-brunch, but it is not clear what it broke exactly.