Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #157

Closed
JoCat opened this issue Jan 4, 2024 · 9 comments · Fixed by #158
Closed

Documentation #157

JoCat opened this issue Jan 4, 2024 · 9 comments · Fixed by #158

Comments

@JoCat
Copy link

JoCat commented Jan 4, 2024

It would be nice to have detailed documentation on the various methods of the library. For example, you could use the typedoc generator.

@JoCat
Copy link
Author

JoCat commented Jan 8, 2024

I can help with integration, the only thing is that English is not my native language, so the documentation may be crooked (I use deepl translator).

@Hacksore
Copy link
Collaborator

I believe something that needs to come before this is a monorepo setup that has been discussed in #107.

Once that is setup it would be very easy to drop in typedoc and something like astro.

@JoCat
Copy link
Author

JoCat commented Jan 10, 2024

Well, typedoc can be added with one command, another thing is that we will need to add comments to the code. And so, yes, I think we should wait for the reorganization of the project, we don't need to complicate things now.

Hacksore added a commit that referenced this issue Jan 13, 2024
@Hacksore
Copy link
Collaborator

@mochaaP can you please approve the vercel app to be added to this repo so I can setup the docs to auto deploy?

@mochaaP
Copy link
Member

mochaaP commented Jan 13, 2024

approved. :)

@Hacksore
Copy link
Collaborator

Docs are live at https://skinview3d-docs.vercel.app but I think #158 might have broken the github pages deploy for some reason.

@mochaaP
Copy link
Member

mochaaP commented Jan 13, 2024

Docs are live at https://skinview3d-docs.vercel.app but I think #158 might have broken the github pages deploy for some reason.

could be github api changes. updating CI deps may work.

@gxres042
Copy link

Docs are live at https://skinview3d-docs.vercel.app but I think #158 might have broken the github pages deploy for some reason.

uses: actions/upload-pages-artifact@v1

I suggest to use actions/upload-pages-artifact@v3

https://github.com/gxres042/skinview3d/blob/125f1b703e01e39461a7bb9ca27e2193f52df78c/.github/workflows/pages.yaml#L52
https://github.com/gxres042/skinview3d/actions/runs/7517237253/job/20463180283

@JoCat
Copy link
Author

JoCat commented Jan 14, 2024

I must have generated the documentation from the wrong file because it even has clear comments, cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants