Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the PCF option DONT_EXPAND_COLORS #11

Closed

Conversation

rodarima
Copy link

@rodarima rodarima commented Mar 2, 2023

Allows the user to specify the complete palette in the PCF, preventing Paraver from expanding the colors.

Fixes bsc-performance-tools/wxparaver#8

Here is an example PCF with a carefully selected palette that contains no dark colors:

DEFAULT_OPTIONS

LEVEL               THREAD
UNITS               NANOSEC
LOOK_BACK           100
SPEED               1
FLAG_ICONS          ENABLED
NUM_OF_STATE_COLORS 1000
YMAX_SCALE          37
DONT_EXPAND_COLORS  1


DEFAULT_SEMANTIC

THREAD_FUNC         State As Is


STATES_COLOR
0   {  0,   0,   0}
1   {229,   0,   0}
2   {183,   0,   0}
3   {229, 106,   0}
4   {193,  89,   0}
5   {235, 174,   0}
6   {202, 151,   0}
7   {235, 235,   0}
8   {196, 197,   0}
9   {152, 235,   0}
10  {125, 192,   0}
11  { 19, 235,   0}
12  { 15, 181,   0}
13  {  0, 235, 234}
14  {  0, 199, 198}
15  {  0, 178, 235}
16  {  0, 152, 200}
17  { 70, 119, 235}
18  { 53,  96, 199}
19  { 70,  73, 235}
20  { 90,   0, 234}
21  { 84,   0, 219}
22  {168,   0, 234}
23  {234,   0, 230}


EVENT_TYPE
0 36         Label
VALUES
1133833770 VeryDark
9770 MaybeDark
31999 31999
32000 32000
32001 32001

And here you can see the comparison when loading a test trace (with increasing values 0, 1, 2, etc.) without and with the new option DONT_EXPAND_COLORS 1, respectively.

timeline-palette

You can see that only the colors defined in the PCF appear in the trace.

Allows the user to specify the complete palette in the PCF, preventing
Paraver from expanding the colors.
@executre
Copy link
Collaborator

@executre executre closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors are too close to background
2 participants