Sql Fields Missing

[awgeorge]

Hello,
Using the table scheme outlined: https://github.com/bshaffer/oauth2-server-php-docs/blob/master/content/cookbook/index.md#mysql--sqlite--postgresql--ms-sql-server causes an error.

It would appear supported_scopes and default_scope is missing from oauth_clients. I stumbled across this following the step-by-step walkthrough exactly.

Are there any more fields missing that you know of?

W

[mellowplace]

I think I've hit the same or similar issue on the cookbook walkthrough.

One of the create table statements given is...

CREATE TABLE oauth_scopes (scope TEXT, is_default BOOLEAN);

When I execute

curl -u testclient:testpass http://localhost/oauth/token.php -d 'grant_type=client_credentials'

I get...

Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42S22]: Column not found: 1054 Unknown column 'type' in 'where clause'' in /home/rob/workspace/google-openconnect/OAuth2/Storage/Pdo.php

It looks like that scope table is at least missing the field "type"

[mellowplace]

I'd recommend packaging a PDO create script for all the tables and including it in the CI tests, that should make sure there's always a reliable way to create the tables. Right now I'm digging through various bits of code.

[mellowplace]

Ok last ramblings on this from me - I found this for MySQL https://github.com/dsquier/oauth2-server-php-mysql/blob/master/oauth.ddl - it contains definitions that work for the oauth2 PHP server 1.2 tag

[bshaffer]

Rob, yes you are right. And I apologize for the inconvenience. Those checked out to the develop branch were reporting the SQL breaking for them, so I updated the docs, which broke the SQL for those implementing the tag. 

I will tag a new version soon, and from then on we will keep the docs in sync with the LATEST TAG, rather than with the development branch. 

As for bundling SQL with the library, I think this too is a great idea. Thank you!
—
Brent Shaffer

On Sun, Jan 26, 2014 at 11:00 AM, Rob Graham notifications@github.com
wrote:

Ok last ramblings on this from me - I found this for MySQL https://github.com/dsquier/oauth2-server-php-mysql/blob/master/oauth.ddl - it contains definitions that work for the oauth2 PHP server 1.2 tag

Reply to this email directly or view it on GitHub:
#11 (comment)

[bshaffer]

We now have the docs point to a tag rather than to develop, so only those riding the "bleeding edge" will experience SQL discrepancies.