refactor: first draft of converting to hooks #122
Conversation
|
Just by the description I'm already loving it. Will review your PR later today. Thank you so much for you efforts! |
|
maybe you could check out my other PRs before that since those contain fixes and features which I'd need to merge in this branch as well |
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "printWidth": 100, | |||
There was a problem hiding this comment.
Since we're out there, I'd prefer 120. I know why 80 is the standard since simpler times (and squared resolutions) but since we're programming in very wide resolutions, I'm more inclined to more space. Would you agree?
| "singleQuote": true, | ||
| "trailingComma": "all", | ||
| "endOfLine": "lf" | ||
| } |
There was a problem hiding this comment.
I'd also add "semi": false here, but I'm fine with either
| @@ -0,0 +1,119 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
There are many rules here that are from coding style, like identation. I think we should leave this kind of thing to prettier and complete ignore from the linter, like Create React App (CRA) does.
There was a problem hiding this comment.
Just to fortify this comment, tools like Prettier plugin and/or Husky + Lint Staged can format the code automatically - so we should never really tell the user if the style is wrong. I don't think that red lines indicating bad identation is good because it's not an error, and shouldn't warn me either. It's just a style, let the IDE do its job (or automation).
There was a problem hiding this comment.
Well the IDE, doesn't matter if VSCode or WebStorm, doesn't format anything without a config. Yes there's a default prettier setting in VSCode but for example I don't have that enabled and it differs between developers what they have setup. Sure it is a lot of configuration stuff but CRA doesn't format without config and neither does husky/lint-staged.
I can remove it as I said ealier, just thought that some sort of styling guidline should be done.
will do! |
this pr is a first draft of converting everything to hooks
so far everything works as intended, the only file i didn't touch right now is the helpers.js since i honestly have no clue what's going on in the withHelpers function
@bsides maybe you can give me some insights there
additionally i've added eslint and prettier configurations, let me know if i should remove them, just thought it might be a good idea since the project wasn't really formatted tbh
i also updated all dependencies since most of them weren't up to date