SQUASH: TEST/ADMIN/DEV/DOC #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADMIN: Improve language about how this doesn't test that docs are properly generated TESTS: * New expect-success test for call with extra spaces between build targets * New expect-failure tests for call with `sphinx-build` option placed before a build target
Per [discussion](sphinx-doc#3841 (comment)) on PR sphinx-doc#3841, re-implemented the argument parsing to eliminate fragility of explicit handling of `sphinx-build` arguments. Syntax now must follow: make target1 target2 ... <sphinxopts>
Add content indicating the structural restriction of `make.bat` invocations, where any options for pass-through to `sphinx-build` must be passed after all build targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_winmake.bat: (ADMIN/TESTS)
ADMIN: Improve language about how this doesn't test that docs
are properly generated
TESTS:
sphinx-buildoption placed before a build targetmake.bat.new_t: (DEV)
Per discussion
on PR sphinx-doc#3841, re-implemented the argument parsing to eliminate fragility of explicit
handling of
sphinx-buildarguments.Syntax now must follow:
make target1 target2 ...
doc/invocation.rst: (DOC)
Add content indicating the structural restriction of
make.batinvocations,where any options for pass-through to
sphinx-buildmust be passed afterall build targets.