Fix windows build on 3.2.1 branch #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works with HUnit-1.6 as well
Successfully compiled with stackage nightly-2017-08-19 using ExposeNative flag
Increased template-haskell upper bounds to 2.13
This eliminates the dependency on template-haskell, which seems to be one of the main causes of build breakage over the last few years.
Fix latest stackage build.
On Windows, there seems to be a minimum size to the client window allowed, likely due to the size of the title bar. Since we're only checking to see that the dimensions were properly updated, we can use different dimensions instead of trying to find failing edge cases (that's a GLFW problem).
This prevents other tests from messing with the attributes before we change what we expect from them.
|
Oh, cool! Have you by chance checked vulkan bindings together with my PR #55 on windows? Last time, I managed to compile |
|
No, I haven't checked it out, but will soon. |
achirkin
pushed a commit
to achirkin/bindings-GLFW
that referenced
this pull request
Nov 26, 2020
Fix windows build on 3.2.1 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of problems:
It also merges in the latest master commits, and bumps the hackage version number. (Windows builds fine after this)