Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

subscribe: file backend #6

Merged
merged 12 commits into from
May 19, 2020
Merged

subscribe: file backend #6

merged 12 commits into from
May 19, 2020

Conversation

mxmCherry
Copy link
Contributor

Decided to start with quite simple file consumer in the end - to polish lint.Subscriber.

@mxmCherry mxmCherry requested a review from dim May 18, 2020 11:07
@mxmCherry mxmCherry changed the base branch from master to feature/subscriber-in-mem May 18, 2020 11:10
@mxmCherry
Copy link
Contributor Author

mxmCherry commented May 18, 2020 •
edited
Loading

TODO for me: switch in-mem impl to lint.Subscriber as well - DONE

dim
dim reviewed May 18, 2020
View reviewed changes
file/example_test.go Outdated Show resolved Hide resolved
file/file.go Outdated Show resolved Hide resolved
file/file.go Outdated Show resolved Hide resolved
file/file.go Outdated Show resolved Hide resolved
file/file.go Outdated Show resolved Hide resolved
@mxmCherry mxmCherry mentioned this pull request May 18, 2020
Merged
@mxmCherry mxmCherry changed the base branch from feature/subscriber-in-mem to master May 18, 2020 15:19
dim
dim reviewed May 19, 2020
View reviewed changes
internal/lint/subscribe.go Outdated Show resolved Hide resolved
dim
dim approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@dim dim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Datas -> Data pls :)

@dim
Copy link
Member

dim commented May 19, 2020

@mxmCherry also, https://travis-ci.org/github/bsm/bps/builds/688422490

@dim
Copy link
Member

dim commented May 19, 2020

Still failing, but merging for now. We need the same "check" mechanism as on bfs, to see if a test suite should be skipped or not

@mxmCherry
Copy link
Contributor Author

I'll merge it myself - it's approved + travis is green.

@mxmCherry mxmCherry merged commit 0f81286 into master May 19, 2020
@mxmCherry mxmCherry deleted the feature/subscriber-file branch May 19, 2020 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dim dim dim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmCherry @dim