This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmCherry
commented
May 19, 2020
mxmCherry
commented
May 19, 2020
dim
reviewed
May 19, 2020
mxmCherry
force-pushed
the
feature/subscriber-kafka
branch
from
May 19, 2020 14:52
99932e2
to
7b2f9d8
Compare
mxmCherry
commented
May 19, 2020
dim
suggested changes
May 20, 2020
Sometimes, messages can be processed not sequentially, like when using kafka with multiple partitions per topic.
dim
approved these changes
May 20, 2020
Merging as is; will address |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.