Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added (manual) Reader & Writer #11

Merged
merged 4 commits into from
Dec 17, 2018
Merged

Added (manual) Reader & Writer #11

merged 4 commits into from
Dec 17, 2018

Conversation

dim
Copy link
Member

@dim dim commented Dec 17, 2018

No description provided.

@dim dim mentioned this pull request Dec 17, 2018
Closed
mxmCherry
mxmCherry reviewed Dec 17, 2018
View reviewed changes
Copy link
Contributor

@mxmCherry mxmCherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should work.

But I really dislike overcomplications with having to deal with bfs.NewObject manually now. I'd really prefer to get rid of this boilerplate - no need for it to be this flexible, IMO - the ONLY application for accepting *bfs.Object are tests.

consumer.go Outdated Show resolved Hide resolved
consumer.go Show resolved Hide resolved
consumer.go Show resolved Hide resolved
feedx_test.go Show resolved Hide resolved
lib/feedx/pusher.rb Outdated Show resolved Hide resolved
@dim
Copy link
Member Author

dim commented Dec 17, 2018 •
edited
Loading

@mxmCherry

with having to deal with bfs.NewObject manually now ...

nothing's changed, NewConsumer still accepts a string URL and deals with objects under the hood. Reader and Writer a more low-level, hence they accept objects directly

@dim dim merged commit 29824ed into master Dec 17, 2018
@mxmCherry
Copy link
Contributor

Ah, sorry, being blind 🤦‍♂️

@dim dim deleted the feature/reader-writer branch June 12, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmCherry mxmCherry mxmCherry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dim @mxmCherry