Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoping out ruby consumer #15

Merged
merged 3 commits into from
Jun 25, 2019
Merged

Scoping out ruby consumer #15

merged 3 commits into from
Jun 25, 2019

Conversation

dim
Copy link
Member

@dim dim commented Jun 20, 2019

@vrih @ajn what do you think? It's effectively doing what Stream does but also supports if_modified_since. Additionally, you can now also pass custom format_options to Producer and Consumer.

dim
dim commented Jun 20, 2019
View reviewed changes
spec/feedx/consumer_spec.rb Outdated Show resolved Hide resolved
@dim dim force-pushed the feature/ruby-consumer branch 3 times, most recently from 2bd06d4 to a3fa071 Compare June 25, 2019 10:38
@dim dim merged commit f0fd10b into master Jun 25, 2019
@dim dim deleted the feature/ruby-consumer branch October 10, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrih vrih vrih left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dim @vrih